androidlover5842/TrisolarisServer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid lazy roomType access in room create/update responses
All checks were successful
build-and-deploy / build-deploy (push) Successful in 32s
Details

Browse Source
This commit is contained in:
androidlover5842
2026-01-27 03:21:38 +05:30
parent 236c885954
commit f9c31a4d59
1 changed files with 24 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/main/kotlin/com/android/trisolarisserver/controller/Rooms.kt
View File

@@ -189,9 +189,19 @@ class Rooms(
notes = request.notes notes = request.notes
) )
val saved = roomRepo.save(room).toRoomResponse() val saved = roomRepo.save(room)
val response = RoomResponse(
id = saved.id ?: throw IllegalStateException("Room id is null"),
roomNumber = saved.roomNumber,
floor = saved.floor,
roomTypeName = roomType.name,
hasNfc = saved.hasNfc,
active = saved.active,
maintenance = saved.maintenance,
notes = saved.notes
)
roomBoardEvents.emit(propertyId) roomBoardEvents.emit(propertyId)
return saved return response
} }
@PutMapping("/{roomId}") @PutMapping("/{roomId}")
@@ -221,9 +231,19 @@ class Rooms(
room.maintenance = request.maintenance room.maintenance = request.maintenance
room.notes = request.notes room.notes = request.notes
val saved = roomRepo.save(room).toRoomResponse() val saved = roomRepo.save(room)
val response = RoomResponse(
id = saved.id ?: throw IllegalStateException("Room id is null"),
roomNumber = saved.roomNumber,
floor = saved.floor,
roomTypeName = roomType.name,
hasNfc = saved.hasNfc,
active = saved.active,
maintenance = saved.maintenance,
notes = saved.notes
)
roomBoardEvents.emit(propertyId) roomBoardEvents.emit(propertyId)
return saved return response
} }
private fun requirePrincipal(principal: MyPrincipal?) { private fun requirePrincipal(principal: MyPrincipal?) {